Repository navigation
Config option: (do not) search default token keys - #1416
Conversation
8e778b0 to
e83773d
Compare
|
@bajtos Some Javadoc may be needed loopback/server/middleware/token.js Line 64 in 9cd1b96 |
Set this option to false to prevent AccessToken from checking default places like "access_token" in query.
e83773d to
986132d
Compare
@OwenBrotherwood good catch, it should be fixed now in 86ed472 |
|
@ritch I forgot to assign this to you in GH, could you PTAL? |
|
Can you make sure the ci is passing? Otherwise the code LGTM. |
|
@slnode test please |
This looks like a problem with downstream dependencies. LoopBack's master fails on our CI build and passes on Travis. This patch passes on Travis and fails on Jenkins. The error messages are the same AFAICT: Was there any breaking change in loopback-testing that would explain this problem? The other test error does not seem to be related to this patch either: I am proposing to land this PR now and investigate the failing build later. @ritch Thoughts? |
Yes. LoopBack should use |
Sounds good. |
Config option: (do not) search default token keys
A follow-up for abandoned #1347.
Add a new option
searchDefaultTokenKeysto the token middleware. Users can set this option to false to prevent AccessToken from checking default places like "access_token" in the request query string.Connect to #1326
/to @ritch please review
/cc @OwenBrotherwood